[webkit-reviews] review denied: [Bug 17952] Add "--cairo" flag to 'build-webkit' command : [Attachment 19887] Extend build-webkit with new "--cairo" build option

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 2 02:43:54 PDT 2008

Darin Adler <darin at apple.com> has denied Brent Fulgham <bfulgham at gmail.com>'s
request for review:
Bug 17952: Add "--cairo" flag to 'build-webkit' command

Attachment 19887: Extend build-webkit with new "--cairo" build option

------- Additional Comments from Darin Adler <darin at apple.com>
+    if (checkArgv("--cairo")) {
+	 $isCairo = 1;
+    } else {
+	 $isWx = 0;
+    }

Seems wrong to set $isWx here.

But also, I think you'd want this setting to be a persistent one. It seems
really inconvenient to have to pass --cairo every single time. It should work
more like configuration where you can set it once and then it's persistent
until you reset it.

review- because of the $isWx mistake, but please consider my suggestion.

More information about the webkit-reviews mailing list