[webkit-reviews] review requested: [Bug 9454] CSS2: Language not inherited from parent element : [Attachment 16473] patch with darin's suggested fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 30 12:39:30 PDT 2007


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 9454: CSS2: Language not inherited from parent element
http://bugs.webkit.org/show_bug.cgi?id=9454

Attachment 16473: patch with darin's suggested fixes
http://bugs.webkit.org/attachment.cgi?id=16473&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
I applied darin's suggested fixes to the patch.  Personally I think this code
will need to be re-written to store the language off of RenderStyle.  It's more
efficient to cascade the language that way, instead of an ancestor crawl.  I'm
not sure that that issue in any way prevents this from landing.  It just kinda
prevents using :lang in the engine. ;)



More information about the webkit-reviews mailing list