[webkit-reviews] review requested: [Bug 14898] XMLHttpRequest.getAllResponseHeaders should separate headers with CRLF : [Attachment 16470] Updated patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 14898: XMLHttpRequest.getAllResponseHeaders should separate headers with
CRLF
http://bugs.webkit.org/show_bug.cgi?id=14898

Attachment 16470: Updated patch
http://bugs.webkit.org/attachment.cgi?id=16470&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
> (From update of attachment 16462 [edit])
> I wonder if this test will really work without being in the http directory?
> (Tests in the http directory are loaded through a local Apache server; all
> other tests are loaded as local files).

I cannot say but I would think it would hit other bugs. Therefore, I moved the
file in the http directory to be sure.

> You probably also meant to say "crlf" in the test name instead of "crcf".

Ops, I did not catch that one. Corrected in the new patch.

Thanks

> r=me for landing on feature-branch.

> Whoever commits this is going to have to make sure to generate test results
(and ensure they are correct, of course).