[webkit-reviews] review denied: [Bug 15299] GTK: ChromeClientGtk.cpp does not implement mouseDidMoveOverElement() : [Attachment 16418] Possible implementation for ChromeClient::mouseDidMoveOverElement()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 28 12:06:53 PDT 2007

Adam Roben <aroben at apple.com> has denied Lars Lindner
<lars.lindner at gmail.com>'s request for review:
Bug 15299: GTK: ChromeClientGtk.cpp does not implement

Attachment 16418: Possible implementation for

------- Additional Comments from Adam Roben <aroben at apple.com>
I think it would be nicer to return early if url.isEmpty() is true instead of
nesting the entire function inside the if.

Your patch contains tabs, which will be disallowed by our pre-commit hook.
Please use indents of 4 spaces instead of tabs. See

Your patch needs a ChangeLog. See <http://webkit.org/coding/contributing.html>
for how to create one.

Thanks for the patch!

More information about the webkit-reviews mailing list