[webkit-reviews] review denied: [Bug 15299] GTK: ChromeClientGtk.cpp does not implement mouseDidMoveOverElement() : [Attachment 16418] Possible implementation for ChromeClient::mouseDidMoveOverElement()

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Lars Lindner
<lars.lindner at gmail.com>'s request for review:
Bug 15299: GTK: ChromeClientGtk.cpp does not implement
mouseDidMoveOverElement()
http://bugs.webkit.org/show_bug.cgi?id=15299

Attachment 16418: Possible implementation for
ChromeClient::mouseDidMoveOverElement()
http://bugs.webkit.org/attachment.cgi?id=16418&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
I think it would be nicer to return early if url.isEmpty() is true instead of
nesting the entire function inside the if.

Your patch contains tabs, which will be disallowed by our pre-commit hook.
Please use indents of 4 spaces instead of tabs. See
<http://webkit.org/coding/coding-style.html>

Your patch needs a ChangeLog. See <http://webkit.org/coding/contributing.html>
for how to create one.

Thanks for the patch!