[webkit-reviews] review requested: [Bug 15002] Script to automatically search nightly builds for regressions (autospade) : [Attachment 16424] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 17:36:19 PDT 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 15002: Script to automatically search nightly builds for regressions

Attachment 16424: Patch v1

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
I think this has baked long enough.  Providing patch for review.  No Windows
support as I don't have a Windows box set up to play with.

Changes since WIP v2:

- Add description of script and instructions on how to create ~/.autospaderc to
override values.
- Created loadConfiguration() subroutine to load variable overrides from a
~/.autospaderc file.
- Renamed $nightlyDirectory to $nightlyDownloadDirectory.
- Made $nightlyDownloadDirectory and $safariPath overrideable via
- Added $safariPath argument to mountAndRunNightly() subroutine.
- Moved subroutine declarations to immediately follow use statements.
- Fixed URLs to list of files and individual nightlies for trunk builds after
feature-branch builds were added.
- Removed r16390 from %knownBadBuilds because it doesn't always crash
(www.google.com works).
- Added r17208 to %knownBadBuilds because that DMG doesn't mount.
- Verified other DMG revisions in %knownBadBuilds either don't mount (r14901,
r15860) or have an unexpected directory structure (r13688).
- Changed behavior for finding starting/ending revisions with --sanity to
expand the range rather than to constrict the range could lead to an invalid
search, and we pay so little for testing slightly larger ranges.
- Fixed a warning about an uninitialized variable in mountAndRunNightly() if no
test URL is given.

More information about the webkit-reviews mailing list