[webkit-reviews] review cancelled: [Bug 15212] Useless checking for Item in FrameLoader::goBackOrForward(int distance) : [Attachment 16290] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 26 02:31:24 PDT 2007


Maxime BRITTO <mbritto at pleyo.com> has cancelled Maxime BRITTO
<mbritto at pleyo.com>'s request for review:
Bug 15212: Useless checking for Item in FrameLoader::goBackOrForward(int
distance)
http://bugs.webkit.org/show_bug.cgi?id=15212

Attachment 16290: proposed patch
http://bugs.webkit.org/attachment.cgi?id=16290&action=edit

------- Additional Comments from Maxime BRITTO <mbritto at pleyo.com>
After the talk mitzpettel and I had, we decided to let the check for the
reachable item in the function because it's more conveniant for the future
updates.
Though I added an assert to help future debug.
I let that last check to avoid an eventually crash on release versions :
    if (item)
	page->goToItem(item, FrameLoadTypeIndexedBackForward);



More information about the webkit-reviews mailing list