[webkit-reviews] review requested: [Bug 14885] LGPL'ed files contain incorrect FSF address : [Attachment 16365] Patch v1 (bzip2 compressed; 740+KB)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 23 15:43:08 PDT 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 14885: LGPL'ed files contain incorrect FSF address
http://bugs.webkit.org/show_bug.cgi?id=14885

Attachment 16365: Patch v1 (bzip2 compressed; 740+KB)
http://bugs.webkit.org/attachment.cgi?id=16365&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Here's a bzip2-compressed patch of the changes (740+KB uncompressed).  The
sed(1) command in Attachment 16267 had the side-effect of adding a newline to
every file it touched (whether a change was made or not, including checksum and
png files), so I did the following instead (using a git working copy):

$ find . -name .git -prune -o -type f -exec grep -l 'Free Software Foundation'
{} \; > fsf.txt
$ for F in `cat fsf.txt`; do perl -p -i -e 's/59 Temple Place.*Suite 330/51
Franklin Street, Fifth Floor/; s/02111-1307/02110-1301/; s/\(51 Franklin
St\)eet/\1reet/;' $F; done

To verify the fix, I also ran these commands (to make sure there were no
results):
$ find . -name .git -prune -o -type f -exec grep -l '59 Temple Place' {} \;
$ find . -name .git -prune -o -type f -exec grep -l '02111-1307' {} \;
$ find . -name .git -prune -o -type f -exec grep -l '51 Franklin Steet' {} \;



More information about the webkit-reviews mailing list