[webkit-reviews] review requested: [Bug 4571] rows in footer must be last in rows HTMLCollection regardless of doc. order : [Attachment 16362] fix HTMLCollection07 and HTMLCollection08

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 23 12:46:58 PDT 2007


Vincent Ricard <magic at magicninja.org> has asked  for review:
Bug 4571: rows in footer must be last in rows HTMLCollection regardless of doc.
order
http://bugs.webkit.org/show_bug.cgi?id=4571

Attachment 16362: fix HTMLCollection07 and HTMLCollection08
http://bugs.webkit.org/attachment.cgi?id=16362&action=edit

------- Additional Comments from Vincent Ricard <magic at magicninja.org>
This patch fixes the test cases HTMLCollection07 and HTMLCollection08, and also
the bug #8133 (maybe it could be marked as duplicated?).

I extended HTMLCollection and overrided traverseNextItem() (rather than modifiy
HTMLCollection::traverseNextItem(), i think is more readable and more
maintenable like this.

I copy/pasted the header for the both new files, i guess the copyright are
wrong; is there a header sample on the wiki or elsewhere?

I ran the tests, and i didnt see new regression.



More information about the webkit-reviews mailing list