[webkit-reviews] review cancelled: [Bug 14998] Full page zooming support : [Attachment 16259] Moved implementation from WebKit to WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 20 05:52:38 PDT 2007

George Wright <george.wright at collabora.co.uk> has cancelled George Wright
<george.wright at collabora.co.uk>'s request for review:
Bug 14998: Full page zooming support

Attachment 16259: Moved implementation from WebKit to WebCore

------- Additional Comments from George Wright <george.wright at collabora.co.uk>
This patch moves the scaleFactor methods from ScrollView into Page. This is
because the scale factor is common to all frames (and hence ScrollView objects)
in a Page, and setting the scale factor in ScrollView does not make it easy to
recurse changes into child ScrollViews in pages with multiple frames, whereas
keeping the scale factor in Page makes more sense as it can be accessed by all
ScrollView objects on that page.

More information about the webkit-reviews mailing list