[webkit-reviews] review denied: [Bug 15228] Missing flex, bison, or gperf produces a failing build : [Attachment 16309] Proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 18 09:48:43 PDT 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Tuukka Hastrup
<Tuukka.Hastrup at iki.fi>'s request for review:
Bug 15228: Missing flex, bison, or gperf produces a failing build

Attachment 16309: Proposed fix

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>+    } elsif (isGdk() or isQt()) {
>+	  my @cmds = qw(flex bison gperf);
>+	  foreach my $cmd (@cmds) {
>+	      if (not `$cmd --version`) {
>+		  die ((join ", ", @cmds) . " required to build WebKit.\n");
>+	      }
>+	  }
>     }

Thanks for taking the time to file a bug and create a patch!  This looks good,
but I'd like to see the code changed to test for all three commands and report
only the ones that are missing.

For example if flex and bison are installed but not gperf, the developer gets a
message about all three being required to build instead of a message about
"gperf" missing.

More information about the webkit-reviews mailing list