[webkit-reviews] review granted: [Bug 15221] Make the FileSystemChooserGdk implementation properly convert the WebCore::String presentation : [Attachment 16304] Convert properly

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 15221: Make the FileSystemChooserGdk implementation properly convert the
WebCore::String presentation
http://bugs.webkit.org/show_bug.cgi?id=15221

Attachment 16304: Convert properly
http://bugs.webkit.org/attachment.cgi?id=16304&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I think "convertToStringByAdoptingTheFilesystemRepresentation" may be a little
bit wordy.  At the least, I think "The" does not add anything.	Elsewhere we
also treat "filesystem" as two words.  Perhaps
"stringWithFileSystemRepresentation" would be a better name?

"filenameSystem" also feels backwards.	"systemFilename" reads better to me.

Other than these naming niggles, r=me.