[webkit-reviews] review denied: [Bug 15221] Make the FileSystemChooserGdk implementation properly convert the WebCore::String presentation : [Attachment 16297] Properly convert the name of the file

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 15221: Make the FileSystemChooserGdk implementation properly convert the
WebCore::String presentation
http://bugs.webkit.org/show_bug.cgi?id=15221

Attachment 16297: Properly convert the name of the file
http://bugs.webkit.org/attachment.cgi?id=16297&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+		 gchar* basename = g_filename_to_utf8(basenameSystem, -1, 0, 0,
0);
+		 g_free(basenameSystem);
+
+		 if (basename) {
+		     string = String::fromUTF8(basename);
+		     g_free(basename);
+		 }

This sequence should be factored out into a static helper function instead of
repeating it twice in this file. Otherwise looks good.