[webkit-reviews] review requested: [Bug 15210] Draw image outline for broken images : [Attachment 16295] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 13:44:04 PDT 2007

Peter Kasting <zerodpx at gmail.com> has asked  for review:
Bug 15210: Draw image outline for broken images

Attachment 16295: patch v2

------- Additional Comments from Peter Kasting <zerodpx at gmail.com>
This subtracts off the outline pixels when calculating the usable dimensions.

It might be good to go even further and subtract 4 in each direction instead of
2, to leave a 1 px buffer inside the outline.  Another possible change to this
patch is that, when there's an error, we could avoid drawing the outline if the
error image would fit without it but not with it (since if you have to pick one
or the other, the error image is probably better than the outline).  Input

More information about the webkit-reviews mailing list