[webkit-reviews] review denied: [Bug 15210] Draw image outline for broken images : [Attachment 16286] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 20:24:47 PDT 2007


Dave Hyatt <hyatt at apple.com> has denied Peter Kasting <zerodpx at gmail.com>'s
request for review:
Bug 15210: Draw image outline for broken images
http://bugs.webkit.org/show_bug.cgi?id=15210

Attachment 16286: patch v1
http://bugs.webkit.org/attachment.cgi?id=16286&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You need to adjust the usableWidth/Height to exclude the drawn outline, since
the error image will potentially draw on top of the outline otherwise.

We'll need to discuss this change I think, since it constitutes a UI change to
Safari.  It's definitely too late to make a change like this for Leopard, so it
will have to wait for a bit.



More information about the webkit-reviews mailing list