[webkit-reviews] review granted: [Bug 15203] [gtk] Don't use FcBool in backend code : [Attachment 16278] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 09:29:15 PDT 2007


Adam Roben <aroben at apple.com> has granted Sven Herzberg <sven at imendio.com>'s
request for review:
Bug 15203: [gtk] Don't use FcBool in backend code
http://bugs.webkit.org/show_bug.cgi?id=15203

Attachment 16278: Proposed Patch
http://bugs.webkit.org/attachment.cgi?id=16278&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    static bool initialized = false;

You don't need to initialize this variable to false (that will happen
automatically as a result of it being declared static).

Please leave the "Reviewed by NOBODY (OOPS!)." line that prepare-ChangeLog
generates for you, as we have pre-commit hooks that prevent anyone from
checking in an unreviewed change this way.

r=me



More information about the webkit-reviews mailing list