[webkit-reviews] review granted: [Bug 15177] [gtk] FontPlatformData contains more fields than required : [Attachment 16254] Final Patch (all in one)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 08:03:10 PDT 2007

Mark Rowe (bdash) <mrowe at apple.com> has granted Sven Herzberg
<sven at imendio.com>'s request for review:
Bug 15177: [gtk] FontPlatformData contains more fields than required

Attachment 16254: Final Patch (all in one)

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Some minor comments:
The local variables inside FontPlatformData::FontPlatformData should lose the
m_ prefix, which is used only for members.  I think the declarations can be
moved to their point of first use too.
Our coding style also requires no space between the function name and it's

I'll make those minor tweaks when I land this.

More information about the webkit-reviews mailing list