[webkit-reviews] review denied: [Bug 15176] run-launcher overwrites LD_LIBRARY_PATH : [Attachment 16249] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 06:52:39 PDT 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied 's request for review:
Bug 15176: run-launcher overwrites LD_LIBRARY_PATH

Attachment 16249: Proposed Patch

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Using $ENV{LD_LIBRARY_PATH} without checking to see if it's set will cause a
"Use of uninitialized value" warning to be printed in the case where it's not
set.  You should do something like:

"$productDir:$ENV{LD_LIBRARY_PATH}" : $productDir;

Setting review- flag to fix this issue.

Please set the "review?" flag on patches in the future if you'd like them to be
reviewed.  (There is no need to set a email address with the review flag.)

Also, please create a ChangeLog entry with the patch.  (The description you
have in your git commit message is great!)


Thanks for reporting this bug!

More information about the webkit-reviews mailing list