[webkit-reviews] review denied: [Bug 15176] run-launcher overwrites LD_LIBRARY_PATH : [Attachment 16249] Proposed Patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied 's request for review:
Bug 15176: run-launcher overwrites LD_LIBRARY_PATH
http://bugs.webkit.org/show_bug.cgi?id=15176

Attachment 16249: Proposed Patch
http://bugs.webkit.org/attachment.cgi?id=16249&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Using $ENV{LD_LIBRARY_PATH} without checking to see if it's set will cause a
"Use of uninitialized value" warning to be printed in the case where it's not
set.  You should do something like:

$ENV{LD_LIBRARY_PATH} = $ENV{LD_LIBRARY_PATH} ?
"$productDir:$ENV{LD_LIBRARY_PATH}" : $productDir;

Setting review- flag to fix this issue.

Please set the "review?" flag on patches in the future if you'd like them to be
reviewed.  (There is no need to set a email address with the review flag.)

Also, please create a ChangeLog entry with the patch.  (The description you
have in your git commit message is great!)

http://webkit.org/coding/contributing.html

Thanks for reporting this bug!