[webkit-reviews] review denied: [Bug 14771] Unbounded memory growth in KJS::UString when repeatedly slicing and prepending/appending : [Attachment 15834] better patch?

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has denied Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 14771: Unbounded memory growth in KJS::UString when repeatedly slicing and
prepending/appending
http://bugs.webkit.org/show_bug.cgi?id=14771

Attachment 15834: better patch?
http://bugs.webkit.org/attachment.cgi?id=15834&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'd like to take this fix, but I think two issues need addressing:

1) The conditions to check whether append or prepend is allowed should be
factored out into some separate inline functions with good clear names. They
are getting complicated enough that it's hard to tell what the actual condition
is.

2) There are other code paths that do similar checks for append, which I think
should be given the same treatment. Let's update all of them at once. In
particular, the three versions of UString::append should be updated.

3) It would be nice to include a test case that would show the unbounded memory
growth without this fix.

Thanks for the fix! I'm looking forward to the updated version.