[webkit-reviews] review denied: [Bug 12221] Webkit ToT fails to render this pattern example : [Attachment 16232] Initial pattern rework patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 9 12:08:11 PDT 2007

Oliver Hunt <oliver at apple.com> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 12221: Webkit ToT fails to render this pattern example

Attachment 16232: Initial pattern rework patch

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Is this safe?
	 if (!attributes.hasX() && current->hasAttribute(SVGNames::xAttr))

This seems really bad to me:

+    CGContextSetPatternPhase(contextRef, CGSizeMake(0.0, -0.01));
What happens under heavy scaling?

-	     attributes.setX(current->x().valueAsPercentage());
+	     attributes.setX(current->x());

More information about the webkit-reviews mailing list