[webkit-reviews] review requested: [Bug 15148] Poor performance on crazy DOM raytracer : [Attachment 16229] Addresses review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 8 14:47:39 PDT 2007

David Smith <catfish.man at gmail.com> has asked  for review:
Bug 15148: Poor performance on crazy DOM raytracer

Attachment 16229: Addresses review comments

------- Additional Comments from David Smith <catfish.man at gmail.com>
>This seems like a gratuitous change:
>-	  for ( ; (r = it.current()); ++it) {
>+	  for ( ; (r = it.current()); ++it ) {

Oops, leftover from a find & replace style fixup. Fixed.

>There's no need to use new here, you can just make the Vector a local
>+    Vector<RenderObject*>* deadObjects = new Vector<RenderObject*>();
>In fact, it might be worthwhile giving it an inline capacity to handle the
>common case effeciently. Something like:
>Vector<RenderObject*, 16> deadObjects;


More information about the webkit-reviews mailing list