[webkit-reviews] review denied: [Bug 15068] [S60] VBRY-763RLF : RTL brackets and alt text are displayed incorrecting : [Attachment 16132] 3.2 patch for RTL text in body and alt text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 5 13:31:02 PDT 2007


Yongjun Zhang <yongjun.zhang at nokia.com> has denied Pat
<vincent.bradley at nokia.com>'s request for review:
Bug 15068: [S60] VBRY-763RLF : RTL brackets and alt text are displayed
incorrecting
http://bugs.webkit.org/show_bug.cgi?id=15068

Attachment 16132: 3.2 patch for RTL text in body and alt text
http://bugs.webkit.org/attachment.cgi?id=16132&action=edit

------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
Possible memory leak here:
+		 // We have a RTL string
+		 TBidiText* bidiText = TBidiText::NewL( newStr, 1,
TBidiText::ERightToLeft );
+		 bidiText->WrapText( WidthForRun( aRun, aStyle ), *iFont );
+		 bidiText->DrawText( bitgc, startPos );

/ bidiText is never deleted.



More information about the webkit-reviews mailing list