[webkit-reviews] review denied: [Bug 15129] adding a new line with DOM does unnecessary additional repaint : [Attachment 16177] patch with ChangeLog, but no repaint test yet (because I don't know how yet)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 15:37:25 PDT 2007


Dave Hyatt <hyatt at apple.com> has denied Darin Adler <darin at apple.com>'s request
for review:
Bug 15129: adding a new line with DOM does unnecessary additional repaint
http://bugs.webkit.org/show_bug.cgi?id=15129

Attachment 16177: patch with ChangeLog, but no repaint test yet (because I
don't know how yet)
http://bugs.webkit.org/attachment.cgi?id=16177&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You need to make sure you don't call absoluteClippedOverflowRect when a full
repaint is happening.  If checkForRepaintDuringLayout is false, then you need
to avoid making that extra call.



More information about the webkit-reviews mailing list