[webkit-reviews] review requested: [Bug 15737] [GTK] A MenuList should look like a GtkComboBox : [Attachment 16970] New RenderThemeGtk implementation (code shared with Mozilla)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 31 16:54:39 PDT 2007


Alp Toker <alp at atoker.com> has asked  for review:
Bug 15737: [GTK] A MenuList should look like a GtkComboBox
http://bugs.webkit.org/show_bug.cgi?id=15737

Attachment 16970: New RenderThemeGtk implementation (code shared with Mozilla)
http://bugs.webkit.org/attachment.cgi?id=16970&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
RenderThemeGtk.cpp is a complete rewrite; any matching lines in the diff are
coincidence or have a shared source from another port.

It now uses code shared with Mozilla to do the dirty work, since the GTK+ style
API contains a lot of quirks which would take a long time to re-discover.

Coding style for the borrowed code should not be modified or reformatted.

I do not know if we need to change the copyright header of the Mozilla sources
to plain LGPL or not, but it would be nice to be able to continue sharing it
under the original license. Thoughts?


More information about the webkit-reviews mailing list