[webkit-reviews] review requested: [Bug 15406] Generated files missing from WebCore's Xcode project file : [Attachment 16951] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 30 16:41:57 PDT 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 15406: Generated files missing from WebCore's Xcode project file

Attachment 16951: Patch v2

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Changes since Patch v1:

- Removed DOMSVGException.h in addition to JSSVGAnimatedPoints.h from
- Don't add DOMSVGPointInternal.h and DOMSVGRectInternal.h to the project file
since those were already fixed.
- Added *Private.h files to the Copy Generated Files Build Phase in WebCore.
- Modified WebKit/MigrateHeaders.make to add the same *Private.h files that
were added to the Copy Generated Headers Build Phase in WebCore.

Note that I did a clean build (wiped WebKitBuild dir) of r27257 and everything
built fine.

More information about the webkit-reviews mailing list