[webkit-reviews] review granted: [Bug 15750] REGRESSION(r27173): Web Inspector freezes beneath Image::drawPattern() : [Attachment 16940] Clamp background tile dimensions up to 1

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has granted mitz at webkit.org's request for review:
Bug 15750: REGRESSION(r27173): Web Inspector freezes beneath
Image::drawPattern()
http://bugs.webkit.org/show_bug.cgi?id=15750

Attachment 16940: Clamp background tile dimensions up to 1
http://bugs.webkit.org/attachment.cgi?id=16940&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    if (!patternTransform.isInvertible()) {
+	 ASSERT_NOT_REACHED();
+	 // Avoid a hang under CGContextDrawTiledImage on release builds.
+	 return;
+    }

I think it would be slightly better to do:

ASSERT(!patternTransform.isInvertible());
if (!patternTransform.isInvertible)
    return;

This way the failed condition will appear on the console, instead of just "NOT
REACHED".

Should the test be text-only?

r=me