[webkit-reviews] review denied: [Bug 15744] Added
FunctionCallResolveNode, PostfixResolveNode,
and DeleteResolveNode to the AST transform : [Attachment 16931] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 28 22:03:09 PDT 2007
Darin Adler <darin at apple.com> has denied 's request for review:
Bug 15744: Added FunctionCallResolveNode, PostfixResolveNode, and
DeleteResolveNode to the AST transform
http://bugs.webkit.org/show_bug.cgi?id=15744
Attachment 16931: Patch
http://bugs.webkit.org/attachment.cgi?id=16931&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+JSValue* LocalVarDeleteNode::evaluate(ExecState* exec)
Unused parameter. Will warn when you merge with my settings.
+ , ident(ident)
+ , args(args.release())
These should both pass PlacementNewAdopt. See my recent patch for details.
Otherwise great!
More information about the webkit-reviews
mailing list