[webkit-reviews] review requested: [Bug 15640] REGRESSION (r17701): Favicons should be viewable as image documents : [Attachment 16930] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 28 21:11:02 PDT 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 15640: REGRESSION (r17701): Favicons should be viewable as image documents
http://bugs.webkit.org/show_bug.cgi?id=15640

Attachment 16930: Patch v1
http://bugs.webkit.org/attachment.cgi?id=16930&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Patch with ChangeLog and layout test.

(In reply to comment #0)
> * NOTES
> The official IANA-registered MIME type for these icons is
> image/vnd.microsoft.icon according to Wikipedia:
> 
> http://en.wikipedia.org/wiki/ICO_(icon_image_file_format)
> 
> The historical MIME type used was image/x-icon.  We should probably support
> both.

Until we have evidence of real web sites returning favicon.ico files with a
MIME type of image/vnd.microsoft.icon, I don't think it's necessary to add this
type.

$ curl --head http://www.microsoft.com/favicon.ico
HTTP/1.1 200 OK
Content-Length: 3638
Content-Type: image/x-icon
Last-Modified: Wed, 11 Oct 2006 22:18:37 GMT
Accept-Ranges: bytes
ETag: "3a71c93283edc61:0"
Server: Microsoft-IIS/7.0
P3P: CP="ALL IND DSP COR ADM CONo CUR CUSo IVAo IVDo PSA PSD TAI TELo OUR SAMo
CNT COM INT NAV ONL PHY PRE PUR UNI"
X-Powered-By: ASP.NET
Date: Mon, 29 Oct 2007 04:10:34 GMT


More information about the webkit-reviews mailing list