[webkit-reviews] review granted: [Bug 15738] a few SunSpider script improvements : [Attachment 16920] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 28 15:48:45 PDT 2007

Adam Roben <aroben at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 15738: a few SunSpider script improvements

Attachment 16920: patch

------- Additional Comments from Adam Roben <aroben at apple.com>
+system("$jsShellPath", "-f", $prefixFile, "-f", $resultsFile, "-f",

You could remove the quotes from around $jsShellPath while you're at it.

+		 $foundOutput = 0;
+		$foundStart = 1;
+		 $result = "[{\n";

Looks like you've got some tabs here.

	} else {
-	    if (/^[}][]]$/) {
+	     print;

Did you intend to insert this print statement?

+		 s/;*$//;

Do we really expect to have multiple semi-colons here?


More information about the webkit-reviews mailing list