[webkit-reviews] review granted: [Bug 10734] HTMLOptionElement should not allow setting the text and index attributes : [Attachment 16913] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 28 14:22:06 PDT 2007


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 10734: HTMLOptionElement should not allow setting the text and index
attributes
http://bugs.webkit.org/show_bug.cgi?id=10734

Attachment 16913: proposed patch
http://bugs.webkit.org/attachment.cgi?id=16913&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Why not add a newline at the end of the test file?

Shouldn't you also remove HTMLOptionElement::setIndex from
HTMLOptionElement.cpp/h?

Otherwise, r=me


More information about the webkit-reviews mailing list