[webkit-reviews] review requested: [Bug 15646] [GTK] caretBlinkFrequency is hard-coded in Frame.cpp : [Attachment 16906] [PATCH] http://bugs.webkit.org/show_bug.cgi?id=15646

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 27 20:05:18 PDT 2007


Alp Toker <alp at atoker.com> has asked  for review:
Bug 15646: [GTK] caretBlinkFrequency is hard-coded in Frame.cpp
http://bugs.webkit.org/show_bug.cgi?id=15646

Attachment 16906: [PATCH] http://bugs.webkit.org/show_bug.cgi?id=15646
http://bugs.webkit.org/attachment.cgi?id=16906&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
[GTK] caretBlinkFrequency is hard-coded in Frame.cpp

Abstract caretBlinkFrequency to RenderTheme.
---
 WebCore/page/Frame.cpp 		 |    4 +---
 WebCore/platform/gtk/RenderThemeGtk.cpp |   23 +++++++++++++++++++++++
 WebCore/platform/gtk/RenderThemeGtk.h	 |    3 +++
 WebCore/rendering/RenderTheme.h	 |    2 ++
 4 files changed, 29 insertions(+), 3 deletions(-)


More information about the webkit-reviews mailing list