[webkit-reviews] review denied: [Bug 15682] Move wx port to TOT : [Attachment 16862] MSVC7 fixes for wxWebKit port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 27 12:39:05 PDT 2007

Eric Seidel <eric at webkit.org> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 15682: Move wx port to TOT

Attachment 16862: MSVC7 fixes for wxWebKit port

------- Additional Comments from Eric Seidel <eric at webkit.org>
please always use static_cast instead of c-style casts.  static_cast is much

I don't understand why your compiler would need you to downcast next.get() and
other calls to Node*.  Those changes look totally bogus.

The rest of the change looks OK.  I wonder if there isn't a better place to add
the pthread include.

More information about the webkit-reviews mailing list