[webkit-reviews] review denied: [Bug 15718] ASSERTION FAILED: _hash in KJS::UString::Rep::computedHash() : [Attachment 16902] fix 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 27 12:20:08 PDT 2007

Darin Adler <darin at apple.com> has denied 's request for review:
Bug 15718: ASSERTION FAILED: _hash in KJS::UString::Rep::computedHash()

Attachment 16902: fix 2

------- Additional Comments from Darin Adler <darin at apple.com>
+    if (!strlen(c)) {

Need the O(1) check of c[0] instead of the O(string-length) check of strlen.

I think it would be even better to do this in UString -- guarantee that null
and empty both have a precomputed hash. It's annoying to have extra overhead in
Identifier::add for 1-time setup.

More information about the webkit-reviews mailing list