[webkit-reviews] review granted: [Bug 15703] fix numeric functions -- improve correctness and speed : [Attachment 16873] patch with detailed change log

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 26 00:33:18 PDT 2007


Maciej Stachowiak <mjs at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 15703: fix numeric functions -- improve correctness and speed
http://bugs.webkit.org/show_bug.cgi?id=15703

Attachment 16873: patch with detailed change log
http://bugs.webkit.org/attachment.cgi?id=16873&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me with one comment:

please consider using trunc(d) instead of copysign(floor(fabs(d))). 

They should do the same thing.


More information about the webkit-reviews mailing list