[webkit-reviews] review denied: [Bug 15669] Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port : [Attachment 16842] Build with -DXP_UNIX and WTF_USE_NPOBJECT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 13:56:55 PDT 2007


Mark Rowe (bdash) <mrowe at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 15669: Build with -DXP_UNIX and WTF_USE_NPOBJECT for GTK+ port
http://bugs.webkit.org/show_bug.cgi?id=15669

Attachment 16842: Build with -DXP_UNIX and WTF_USE_NPOBJECT
http://bugs.webkit.org/attachment.cgi?id=16842&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I really think the #undef's need to be isolated to a single location with a
comment explaining why they are needed.

You also need to include ChangeLog entries with your patch.


More information about the webkit-reviews mailing list