[webkit-reviews] review denied: [Bug 15658] Speed up SunSpider by 2.2% by removing checks for isOutOfMemory() : [Attachment 16831] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 24 09:35:31 PDT 2007


Darin Adler <darin at apple.com> has denied 's request for review:
Bug 15658: Speed up SunSpider by 2.2% by removing checks for isOutOfMemory()
http://bugs.webkit.org/show_bug.cgi?id=15658

Attachment 16831: fix
http://bugs.webkit.org/attachment.cgi?id=16831&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This version of the patch isn't quite right. For one thing, once memoryFull is
set true, this patch will *never* set it back to false. That was not the old
behavior.

For another, we hit an assertion immediately in the debug build because
operationInProgress is still true.


More information about the webkit-reviews mailing list