[webkit-reviews] review denied: [Bug 15642] Report build errors to users on Windows : [Attachment 16821] Patch to report build errors on Windows

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 15642: Report build errors to users on Windows
http://bugs.webkit.org/show_bug.cgi?id=15642

Attachment 16821: Patch to report build errors on Windows
http://bugs.webkit.org/attachment.cgi?id=16821&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    if (1 || exitStatus($result)) {

I assume the "1 ||" was for debugging purposes? In any case I think it should
be removed.

+sub getRelativeScriptsDir()

I don't think the "get" prefix is helpful here.

It would be great at some point to enhance the script to look through the build
logs to figure out which project(s) failed and point the user at those logs
more specifically.

I'll r+ once the above two issues are fixed.