[webkit-reviews] review granted: [Bug 15617] improve speed of integer conversions : [Attachment 16803] patch with change log (newer version with fixed .exp file)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 10:49:29 PDT 2007

Eric Seidel <eric at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 15617: improve speed of integer conversions

Attachment 16803: patch with change log (newer version with fixed .exp file)

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great.  I assume you ran the tests.  Also, (pot calling the kettle black
here) I think it would be nice to replace all your float special values
4294967296.0, etc with some nice names (to make the code make sense to someone
who didn't just hack on it for a couple hours. :)  (Also, nice catch with
toInt32SlowCase calling toUInt32.  I'm curious if that would ever be "wrong"
(such that we could build a test).  I guess it just changes what values could
be stored in the float, since it's just doing the sign wrap at a different

More information about the webkit-reviews mailing list