[webkit-reviews] review granted: [Bug 15605] add crypto tests to sunspider : [Attachment 16775] crypto tests: AES, MD5 and SHA-1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 21 20:22:14 PDT 2007

Eric Seidel <eric at webkit.org> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 15605: add crypto tests to sunspider

Attachment 16775: crypto tests: AES, MD5 and SHA-1

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  As I noted in IRC, the only issues I could foresee are 1. 
polluting the global object (and thus putting memory pressure on later tests)
and 2. none of these test check correctness (to make sure they don't break in
the future).  A simple comparison of original plain and decrypted text in aes,
and comparison with known-good hash values for md5 and sha1.  But none of these
are major issues, and you should feel free to address them later.

More information about the webkit-reviews mailing list