[webkit-reviews] review denied: [Bug 15584] REGRESSION(r26696): GtkLauncher segfaults on WebCore::WidthIterator::advance : [Attachment 16755] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 20 19:47:59 PDT 2007


Darin Adler <darin at apple.com> has denied Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 15584: REGRESSION(r26696): GtkLauncher segfaults on
WebCore::WidthIterator::advance
http://bugs.webkit.org/show_bug.cgi?id=15584

Attachment 16755: Patch
http://bugs.webkit.org/attachment.cgi?id=16755&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Good fix. But we really should structure this so we don't call
glyphDataForCharacter twice; it can be an expensive operation. If references
make this too tricky, you can use a const GlyphData*.


More information about the webkit-reviews mailing list