[webkit-reviews] review denied: [Bug 15563] Should use KJS::Window
and avoid using;
due to conflict with X11 Window : [Attachment 16731] Patch to use
KJS::Window instead of just Window where appropriate
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 10:56:21 PDT 2007
Darin Adler <darin at apple.com> has denied Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 15563: Should use KJS::Window and avoid using; due to conflict with X11
Window
http://bugs.webkit.org/show_bug.cgi?id=15563
Attachment 16731: Patch to use KJS::Window instead of just Window where
appropriate
http://bugs.webkit.org/attachment.cgi?id=16731&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I don't think the references to Window that are inside the KJS namespace need
to change. So that means we don't need any changes to kjs_window.h,
JSXMLHttpRequest.cpp, or kjs_binding.cpp.
Could you try tossing the changes to those files?
Otherwise this looks great.
More information about the webkit-reviews
mailing list