[webkit-reviews] review denied: [Bug 15558] DumpRenderTree should support automated printing tests : [Attachment 16728] improved fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 20:21:19 PDT 2007


Adam Roben <aroben at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 15558: DumpRenderTree should support automated printing tests
http://bugs.webkit.org/show_bug.cgi?id=15558

Attachment 16728: improved fix
http://bugs.webkit.org/attachment.cgi?id=16728&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+# No support for printAsPDF() in DRT
+printing
+

Could you stick this up near the top of the file, near where we skip
webarchive?

Index: LayoutTests/platform/mac/printing/media-queries-print-expected.txt

I think we should have a .pdf extension for this so that it's easily viewable
in Preview. We may have to change run-webkit-tests to know to use diff on .pdf
files.


More information about the webkit-reviews mailing list