[webkit-reviews] review requested: [Bug 12159] Most of CSSComputedStyleDeclaration, cssparser.cpp, cssstyleselector.cpp should be autogenerated : [Attachment 16692] updated patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12159: Most of CSSComputedStyleDeclaration, cssparser.cpp,
cssstyleselector.cpp should be autogenerated
http://bugs.webkit.org/show_bug.cgi?id=12159

Attachment 16692: updated patch
http://bugs.webkit.org/attachment.cgi?id=16692&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
(In reply to comment #8)

> The checking here seems unnecessary. I think we can just omit it.

Done.

> Do we have test cases that cover all the different length types and property
> values?

Hmm, I think the tests in css1/ and css2.1/ cover this.

> I think that needing to do this is quite unfortunate. Because of this, I'm
not
> happy with the template conversion technique. Can we switch to a simpler
> technique that doesn't involve templates?

Attached is another attempt to save the template technique :)