[webkit-reviews] review denied: [Bug 15409] FrameLoaderClientGtk
hardcodes data, including platform to Linux i686 :
[Attachment 16590] Use GTK+ instead of X11;
U. Also unhardcode the language.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 16 09:39:16 PDT 2007
Adam Roben <aroben at apple.com> has denied Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 15409: FrameLoaderClientGtk hardcodes data, including platform to Linux
i686
http://bugs.webkit.org/show_bug.cgi?id=15409
Attachment 16590: Use GTK+ instead of X11; U. Also unhardcode the language.
http://bugs.webkit.org/attachment.cgi?id=16590&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+ m_userAgent = (WebCore::String)"Mozilla/5.0 (GTK+; " + un.sysname + " " +
un.machine + "; " + g_get_language_names()[0] + ") AppleWebKit/420+ (KHTML,
like Gecko)";
I think it would be better to use String::format() here instead of building
this string by appending.
We should also add a FIXME about getting the version number correct.
More information about the webkit-reviews
mailing list