[webkit-reviews] review denied: [Bug 15356] getResponseHeader and getAllResponseHeaders do not throw exceptions : [Attachment 16596] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 15 09:19:39 PDT 2007

Darin Adler <darin at apple.com> has denied Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 15356: getResponseHeader and getAllResponseHeaders do not throw exceptions

Attachment 16596: Updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
+	 // Should raise a SYNTAX_ERR exception
+	 // but Opera and IE returns an empty string, so we just return an
empty string

We should get this fixed in the XMLHttpRequest specification if browsers really
can't follow it and be compatible.

Is there really a need to add the isValidToken check? What's the behavior if we
leave it out? Do any of the tests you wrote fail if you leave out the
isValidToken check?

+	     //used to call getResponseHeader but could raise unnecessary

I don't think that's a helpful comment. Please just leave it out.

+    String getAllResponseHeaders(ExceptionCode& ec) const;
+    String getResponseHeader(const String& name, ExceptionCode& ec) const;

The argument doesn't need a name in the header (see the setRequestHeader above
for an example of how we write these).

review- mainly because of the isValidToken question

More information about the webkit-reviews mailing list