[webkit-reviews] review requested: [Bug 12159] Most of CSSComputedStyleDeclaration, cssparser.cpp, cssstyleselector.cpp should be autogenerated : [Attachment 16667] Move enum mapping into a separate file

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12159: Most of CSSComputedStyleDeclaration, cssparser.cpp,
cssstyleselector.cpp should be autogenerated
http://bugs.webkit.org/show_bug.cgi?id=12159

Attachment 16667: Move enum mapping into a separate file
http://bugs.webkit.org/attachment.cgi?id=16667&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This patch is IMHO helpful regardless of whether we decide to auto-generate any
more code.

The CSSComputedStyleDeclaration part is pretty straightforward. In
CSSStyleSelector, there was some error checking I don't quite understand,
especially because not all cases have it. I might have removed something
important, or kept something unnecessary.

-	 if (!primitiveValue || !primitiveValue->getIdent())
-	     return;
...
-    if (!value->isPrimitiveValue()) return;

It seems that these are guaranteed by the parser. Similarly, some checks for
unexpected ident values may have changed, but it doesn't seem that they
actually come into play unless memory is overwritten.