[webkit-reviews] review granted: [Bug 15451] SVGStyledElement must unregister itself from Resources on detach : [Attachment 16622] Again, this time handling the SVGResource destruction as well

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 15451: SVGStyledElement must unregister itself from Resources on detach
http://bugs.webkit.org/show_bug.cgi?id=15451

Attachment 16622: Again, this time handling the SVGResource destruction as well
http://bugs.webkit.org/attachment.cgi?id=16622&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Style guidelines:
+    ResourceSet() 
+    {

 SVGResource::~SVGResource()
is a bit too clever for my tastes.  

If you break it into two for loops (you can even use the same itr variable) it
would be easier to understand. (I think).

I would still change "item" to "element" or something more appropriate now that
these things aren't KCanvasItems anymore (the old name for RenderPath.. back
when the renderers used to be clients directly).

I dont' need to see this again, but please do those small fixes when you land.