[webkit-reviews] review denied: [Bug 15076] deg2rad has multiple definitions : [Attachment 16609] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 10 07:44:58 PDT 2007


Darin Adler <darin at apple.com> has denied Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 15076: deg2rad has multiple definitions
http://bugs.webkit.org/show_bug.cgi?id=15076

Attachment 16609: Proposed patch
http://bugs.webkit.org/attachment.cgi?id=16609&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This patch adds conversions to/from double in code that was previously dealing
entirely with floats. That will make the code slower. Instead there should be
overloaded versions of these functions for both float and double.


More information about the webkit-reviews mailing list