[webkit-reviews] review requested: [Bug 15356] getResponseHeader and getAllResponseHeaders do not throw exceptions : [Attachment 16596] Updated patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 15356: getResponseHeader and getAllResponseHeaders do not throw exceptions
http://bugs.webkit.org/show_bug.cgi?id=15356

Attachment 16596: Updated patch
http://bugs.webkit.org/attachment.cgi?id=16596&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
Concerning Darin's comment about regression, I did some testing (as I told you
I would) and updated the patch and the tests according to the results.

For INVALID_STATE_ERR :

IE7 : raise an exception when readyState < 4
FF 3 : has a buggy behaviour that depends on the version I have used but i does
raise an exception at some point before readyState 3.
Opera : raise an exception when readyState < 3

Here raising an exception when readyState < 3 seems the right behaviour and I
have not changed that part.

For SYNTAX_ERROR :

IE 7 & Opera : returns an empty string
Firefox : returns null

I sided with Opera and IE and returned an empty string if the requested header
is not valid.