[webkit-reviews] review denied: [Bug 14824] REGRESSION(r14258): +setMIMETypesShownAsHTML has no effect if MIME type is text/* (works in Safari 2, doesn't work in Safari 3) : [Attachment 15845] Patch to fix regression from Bug 14882

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 11:41:13 PDT 2007


Brady Eidson <beidson at apple.com> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 14824: REGRESSION(r14258): +setMIMETypesShownAsHTML has no effect if MIME
type is text/* (works in Safari 2, doesn't work in Safari 3)
http://bugs.webkit.org/show_bug.cgi?id=14824

Attachment 15845: Patch to fix regression from Bug 14882
http://bugs.webkit.org/attachment.cgi?id=15845&action=edit

------- Additional Comments from Brady Eidson <beidson at apple.com>
What does this patch do?

It feels like it is more focused on solving the regression I caused re:
downloading text files, but that regression has already been fixed.

I can't see how, with this patch, text mime types *can* be registered as HTML,
and thats the bug that remains to be solved here.

If I'm completely off base and theres an explanation how, I will totally
re-review :)



More information about the webkit-reviews mailing list