[webkit-reviews] review denied: [Bug 13141] XMLHttpRequest should set readyState to 0 after abort() : [Attachment 16553] Patch updated according to Darin comments

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied 's request for review:
Bug 13141: XMLHttpRequest should set readyState to 0 after abort()
http://bugs.webkit.org/show_bug.cgi?id=13141

Attachment 16553: Patch updated according to Darin comments
http://bugs.webkit.org/attachment.cgi?id=16553&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Actually, this doesn't seem to do what the specification says, namely, step 4
says that readystatechange event shouldn't be fired when zeroing out the state.
Perhaps it would be appropriate to implement the rest of the algorithm in this
patch, but that can be done later, too.

1. Abort the send() algorithm, set the response entity body to "null", the
error flag to "true" and remove any registered request headers.

2. The user agent should cancel any network activity for which the object is
responsible.

3. If the state is UNSENT, OPENED and the send() flag is "false", or DONE go to
the next step.

Otherwise, switch the state to DONE, set the send() flag to "false" and
synchronously dispatch a readystatechange event on the object.

4. Switch the state to UNSENT. (Do not dispatch the readystatechange event.)


Sorry for not catching this earlier.